Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tx data version byte #9845

Merged
merged 3 commits into from
Mar 13, 2024
Merged

feat: add tx data version byte #9845

merged 3 commits into from
Mar 13, 2024

Conversation

tchardin
Copy link
Contributor

Description

This PR adds a tx data version byte incrementing DerivationVersion0 as a way to flag commitments from l1 retrieval vs regular input data from L1 DA.

Tests

Included a unit test to validate that any data without the right byte prefix is forwarded downstream to be parsed as input data.

Additional context

This feature should help with migrating between plasma and L1 DA.

Metadata

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2024 •
edited
Loading

Walkthrough

Walkthrough

The changes involve establishing a new versioning system for plasma commitment transactions in the batch submission process. The introduction of TxDataVersion1 signifies plasma transactions, enhancing compatibility for parsing and ensuring accurate processing. These updates standardize how transaction data is managed and validate data types, offering a more coherent approach to handling plasma transactions across system components.

Changes

Files Change Summary
op-batcher/batcher/driver.go
op-e2e/actions/l2_batcher.go
op-plasma/commitment.go		 Replaced encoding of plasma commitments with TxData method using TxDataVersion1 for plasma transaction version signaling.
op-e2e/actions/plasma_test.go Updated to exclude the version byte in tx.Data during assignment to lastComm.
op-node/rollup/derive/params.go Introduced TxDataVersion1 constant for plasma input transactions.
op-node/rollup/derive/plasma_data_source.go
op-node/rollup/derive/plasma_data_source_test.go		 Implemented checks for transaction data type and revised data field assignment to utilize TxData(TxDataVersion1).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

tynes
tynes reviewed Mar 13, 2024
View reviewed changes
op-plasma/commitment.go Outdated Show resolved Hide resolved
trianglesphere
trianglesphere approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs should updated with the fact that we now accept calldata & DA data with the plasma enabled.

op-node/rollup/derive/plasma_data_source.go Show resolved Hide resolved
@trianglesphere trianglesphere mentioned this pull request Mar 13, 2024
Merged
@trianglesphere trianglesphere added this pull request to the merge queue Mar 13, 2024
Merged via the queue into ethereum-optimism:develop with commit 022af5b Mar 13, 2024
73 checks passed
@emilianobonassi emilianobonassi mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes left review comments

@trianglesphere trianglesphere trianglesphere approved these changes

@protolambda protolambda Awaiting requested review from protolambda

@ajsutton ajsutton Awaiting requested review from ajsutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tchardin @tynes @trianglesphere